Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LF as line ending for banner and identification string #761

Closed
DkGr opened this issue Jan 12, 2021 · 7 comments
Closed

Support LF as line ending for banner and identification string #761

DkGr opened this issue Jan 12, 2021 · 7 comments
Milestone

Comments

@DkGr
Copy link

DkGr commented Jan 12, 2021

This error appear with some SSH host :

The server response contains a null character at position 0x0000002A:

00000000 53 53 48 2D 32 2E 30 2D 4F 70 65 6E 53 53 48 5F SSH-2.0-OpenSSH_
00000010 37 2E 34 70 31 20 52 61 73 70 62 69 61 6E 2D 31 7.4p1 Raspbian-1
00000020 30 2B 64 65 62 39 75 37 0A 00 0+deb9u7..

A server must not send a null character before the Protocol Version Exchange is complete.

More information is available here:
https://tools.ietf.org/html/rfc4253#section-4.2

Null character can be part of the identification string ?

@drieseng drieseng changed the title Null character error with Protocol Version Exchange Support LF as line ending for banner and identification string Jan 12, 2021
@drieseng
Copy link
Member

@DkGr @Kim-SSi @jimbobmcgee Please confirm that this issue is fixed in 91b6458.

@drieseng drieseng modified the milestones: 2020.0.1, 2020.0.0 Jan 12, 2021
@DkGr
Copy link
Author

DkGr commented Jan 12, 2021

Fixed for me. Good job ! Thank you.

@Kim-SSi
Copy link

Kim-SSi commented Jan 12, 2021

This also fixed it for me. Great. Thank you.

@slim16165
Copy link

Thanks a lot guys for solving this issue. I had it with Cloudways. The last code works nicely, can you release the updated 2020.0.1 on nuget?
ps: I owe you a beer @drieseng

@mattzink
Copy link

We are also seeing this issue with certain builds of OpenSSH. I would like to second @slim16165's suggestion to release a build with this fix.

@drieseng
Copy link
Member

Sorry guys, I don't have a lot of spare cycles. I hope to find time this weekend.

@drieseng
Copy link
Member

Release 2020.0.1 is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants