Bugfix/shell stream stopping event on chanell close #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for the test cases.
|
|
|
Oh sorry - Didnt realise you had the automated checks. Will push the unit tests shortly. |
|
That is a socksProxy test case that is failing on a Mocked exception. Not related to my code change. |
|
Sorry busy for now. Will get back to this in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ShellStream on channel close disposes of itself instead of leaving the task to the owner of the object.
Requires Starting and Stopping semantics same as for underlying shell.
Full Bug fix for #44