Remove placeholder tests #1183
Merged
Remove placeholder tests #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
requested review from
drieseng and
WojciechNagorski
as code owners
|
@drieseng I very like this idea. I want to generate a code coverage raport to the next version and for each PR. |
drieseng
requested changes
Oct 13, 2023
|
@Rob-Hague, @WojciechNagorski: I suppose we want to merge this one before we merge the PR where we move the test projects. |
|
@drieseng I think it's a good idea. |
WojciechNagorski
approved these changes
Oct 14, 2023
WojciechNagorski
added a commit
that referenced
this pull request
Oct 14, 2023
* Enable list directory async for net framework (#1206) * Enable ListDirectoryAsync for .NET Framework * Removed (now) unused constant. * Remove placeholder tests (#1183) * Remove placeholder tests * Move Reverse perf test to benchmarks project --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Fix integration test after moving test projects --------- Co-authored-by: Patrick-3000 <38472350+Patrick-3000@users.noreply.github.com> Co-authored-by: Rob Hague <rh@johnstreetcapital.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have no value and make it harder to trace references with intellisense. Removing them also helps narrow down the tests we need to address
Before:
After:
(the 3 extra passing tests is
ExtensionsTest_Reverse.Nullfor each tfm and the 2 failing tests are #1166)