Rebased AsyncResult fix #1184
Merged
Rebased AsyncResult fix #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
requested review from
drieseng and
WojciechNagorski
as code owners
Rob-Hague
force-pushed
the
FixAsyncResultInvalidValue
branch
from
d7688de
to
90e848b
Compare
Rob-Hague
force-pushed
the
FixAsyncResultInvalidValue
branch
from
90e848b
to
6b1595b
Compare
|
I am seeing strange failures of this test locally. The failures are not the original "uploaded/downloaded bytes do not match" assertion, rather some kind of channel closed/timeout exception such as "Renci.SshNet.Common.SshOperationTimeoutException: Session operation has timed out". I thought I had narrowed it down and was able to reproduce the behaviour, but then it started behaving differently and now I have no idea what's going on. |
|
Can you remove this in this PR |
- AsyncResult should contain invalid value immediately after async operation is marked as completed - there was race condition problems with callback method which is invoked on different thread so updating of value is done without any synchronization. So in some cases async operation is marked as completed but async result value is not yet updated and contains invalid value
Rob-Hague
force-pushed
the
FixAsyncResultInvalidValue
branch
from
c0fd3df
to
8b21031
Compare
|
Thanks, I had done that locally but forgot to push... |
|
@Rob-Hague It looks like it works. Is it ready for review? |
|
Yes I think so, I think there were gremlins in my PC |
WojciechNagorski
approved these changes
Dec 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #680 by @miroslavpokorny brought up to date.
I have been seeing occasional failures of the
Test_Sftp_Multiple_Async_Upload_And_Download_10Files_5MB_Eachtest.When choosing "Run until failure" in Visual Studio, the test failed after 20, 9, 45, 32 and 10 attempts. With this change, it ran successfully over 300 times before I stopped it.
Fixes #329
Side note: I'm not really sure why these Begin/End methods have an extra "callback" parameter as well as an
AsyncCallbackparameter, but I'm hoping we can just get rid of these methods soon anyway, or at least have them wrap a task based implementation