Upgrade packages #1279
Upgrade packages #1279
Conversation
Rob-Hague
requested review from
drieseng and
WojciechNagorski
as code owners
| @@ -34,9 +34,8 @@ | |||
| Use fixed version of analyzers. | |||
| --> | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview1.23165.1" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
Remove reference to Microsoft.CodeAnalysis.NetAnalyzers (use the stable version by default)
You should not remove this package because of .NET Framework do not have analyzers by default, should you?
There was a problem hiding this comment.
According to https://www.nuget.org/packages/Microsoft.CodeAnalysis.NetAnalyzers, it is included by virtue of <EnableNETAnalyzers>true</EnableNETAnalyzers> on line 21
There was a problem hiding this comment.
But I think you still need to install Nuget. Can you check it?
There was a problem hiding this comment.
The packages README says
You do not need to manually install this NuGet package to your project if you are using .NET5 SDK or later
We are using .NET8 SDK. An example of a CA analyzer on net462 target:
I did not upgrade Meziantou.Analyzer because the release notes show some new analyzers so it probably needs more attention there.