Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async support to SftpClient and SftpFileStream #819
Add async support to SftpClient and SftpFileStream #819
Changes from 2 commits
ca1a59f
5f74049
d5c80f5
d578af7
c37a884
ed8e789
a33cab8
2235756
6fb5be2
b7fd333
85839e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason for adding .NET 4.6 support at this stage.
You remark about SshNet.Security.Cryptography is not correct. It does have a strong name.
If you really want to add a new target framework for the desktop, then I'd add .NET Framework 4.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe drop some target frameworks?
"netstandard2.0 ought to be enough for anybody"
.NET Framework 4.5.2, 4.6, 4.6.1 will reach End of Support on April 26, 2022
Is there reason to add net46 when .NET Framework 4.6 is .NET Standard 1.3 compatible, and .NET Framework 4.6.1 is .NET Standard 2.0 compatible?
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher
I have no details on what exactly is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
net46 target is needed to use
TaskCreationOptions.RunContinuationsAsynchronously
.@vanillajonathan I have a couple of projects targeting net472 where I've had problems if the referenced libraries targeted net45+ AND netstandard 2.0. There is also a discussion about specific intricacies on dotnet repo, but I don't have the link at hand right now.
This is quite a tricky topic that I feel should be discussed further in #665 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgorMilavec, is it ok for you to target .NET Framework 4.7.2 (or 4.8) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've raised the target to net472.