Fix SocketAsyncEventArgsAwaitable calling continuation multiple times #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been running in my test environment for a couple of days and it seems there are no regressions. |
|
What are the chances of getting this merged into the main development branch? I haven't personally tested it, but it would be helpful if the fix actually works. The ConnectAsync function is basically unusable without it since it can cause an unhandled exception. I've had to stick with the Synchronous Connect instead because I was seeing the same issue noted in #913. Cancelling the token while waiting for ConnectAsync to return for a device that is not reachable will cause the exception. |
IgorMilavec
requested review from
WojciechNagorski and
Rob-Hague
as code owners
Rob-Hague
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is some cases
SocketAsyncEventArgsAwaitablewas calling continuations multiple times due to improper state transition.This will fix #913