Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Comments in Exclusion File #859

Closed
mhd-jalilvand opened this issue May 25, 2023 · 0 comments
Closed

Support for Comments in Exclusion File #859

mhd-jalilvand opened this issue May 25, 2023 · 0 comments

Comments

@mhd-jalilvand
Copy link

Description:
I would like to request support for comments in the exclusion file when using sshuttle with the -X option. Currently, comments are not recognized, and it would be helpful to have the ability to add comments for better organization and documentation purposes.

Expected Behavior:
I expect that lines starting with a designated character, such as "#" or "//", should be treated as comments and ignored by sshuttle when parsing the exclusion file.

Steps to Reproduce:

  1. Create an exclusion file with domains to exclude.
  2. Add comment lines starting with a designated character.
  3. Run sshuttle with the exclusion file using the -X option.
  4. Observe that comments are not ignored, and the tool tries to interpret them as domains.

Additional Information:

  • I have seen other tools and scripts that support comments in configuration files using a designated character at the beginning of the line.
  • The ability to include comments would greatly improve the readability and maintainability of exclusion files.

Environment:

  • sshuttle version: 1.1.1
  • Operating System: Ubuntu

Please let me know if any further information is needed. Thank you for considering this feature request!

@mhd-jalilvand mhd-jalilvand closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant