Remove unstable references, removed wrapper div and update dependencies #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey, @erictompkins, Thank you for taking your time and effort to make our project better.
|
@sshyam-gupta All of your requested changes have been made. Thank you! |
sshyam-gupta
changed the title
sshyam-gupta
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core reason for the update is to remove the wrapper
divaround the content. We're using a grid layout and using ReactModal to show the content. In this case the content is displayed out of the root directory, but thedivthat you have around the content affects our grid layout.Change the
divto a fragment solves that.I also updated the packages and updated the
unstable_references to their current objects.