Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Add support for laravel 11, test on php 8.3, remove old laravel versions #11

Merged
merged 5 commits into from
Mar 17, 2024

Conversation

steache
Copy link
Contributor

@steache steache commented Mar 14, 2024

No description provided.

@ssi-anik
Copy link
Owner

ssi-anik commented Mar 16, 2024

@steache I am sorry for replying this late.

I was thinking of dropping L6,7,8,9 and only keeping L10 and onwards with PHP ^8.1

Can you make those changes on the composer as well as the workflow yml files?

TIA.


EDIT: also in the readme, in case someone wants to use the removed versions, they get forwarded to the older versions.

@steache steache changed the title Fix: Add support for laravel 11, test on php 8.3 Breaking: Add support for laravel 11, test on php 8.3, remove old laravel versions Mar 17, 2024
@steache
Copy link
Contributor Author

steache commented Mar 17, 2024

  • @ssi-anik so something like this?
  • I've removed old versions
  • I did not get the part with readme. :)
  • I've changed the title, becase this will be breaking change, not fix.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (8759b81) to head (ff53b72).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     99.31%   99.31%           
  Complexity       84       84           
=========================================
  Files             6        6           
  Lines           292      292           
=========================================
  Hits            290      290           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssi-anik
Copy link
Owner

@steache thanks mate.

Those Laravel versions are already deprecated and there is no code-related change so far. So I dropped all those previous versions. And, I am going to make a new tag so the upcoming changes (if any) should go under new tags.

Finally, thanks for the help. 🙏

@ssi-anik ssi-anik merged commit 170f9ea into ssi-anik:master Mar 17, 2024
8 checks passed
@ssi-anik
Copy link
Owner

@steache I have added new tag v2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants