Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI tests #80

Merged
merged 37 commits into from
Jan 17, 2024
Merged

Improve CI tests #80

merged 37 commits into from
Jan 17, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jan 12, 2024

Intent

Fixes #62
Fixes #78

Approach

For diseasystore we have been restructuring the workflows.
These workflows are available on https://github.com/ssi-dk/AEF-DDF/

This PR implements these workflows which have improved triggering conditions (fixes #62) and
separated test by DB backend (including SQL sever - fixes #78)

This requires some changes to setup.R and the test now draw their connections from get_test_conns()

A few tests had to be adjusted / removed in this new testing context

Known issues

This PR uses workflows from AEF-DDF that are not yet merged into main

This PR is based on rc-v0.3 which is not yet merged into main

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

RasmusSkytte and others added 30 commits January 10, 2024 14:50
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Jan 12, 2024
@RasmusSkytte RasmusSkytte self-assigned this Jan 12, 2024
@RasmusSkytte RasmusSkytte reopened this Jan 15, 2024
@RasmusSkytte RasmusSkytte reopened this Jan 15, 2024
@RasmusSkytte RasmusSkytte marked this pull request as ready for review January 15, 2024 15:12
Copy link
Collaborator

@marcusmunch marcusmunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was a mouthful—especially 0d43c2d.

I suppose that you intended to keep every commit as "complete" as possible, which in turn made the git diff quite hard to grasp. For the future, consider separating the commit into (for lack of better words) functional and syntactical changes in order to better reveal any actual changes to test functionality.

.github/workflows/r-license-report.yaml Outdated Show resolved Hide resolved
vignettes/basic-principles.Rmd Show resolved Hide resolved
@marcusmunch marcusmunch force-pushed the feature/mssql_tests branch 2 times, most recently from 5ac6d20 to 606253f Compare January 17, 2024 13:50
@RasmusSkytte RasmusSkytte merged commit fe0768f into main Jan 17, 2024
24 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/mssql_tests branch January 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing framework for Microsoft SQL Server Revisit workflow trigger conditions
2 participants