-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI tests #80
Improve CI tests #80
Conversation
f7d011b
to
569d877
Compare
dfd8d57
to
1110776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that was a mouthful—especially 0d43c2d.
I suppose that you intended to keep every commit as "complete" as possible, which in turn made the git diff quite hard to grasp. For the future, consider separating the commit into (for lack of better words) functional and syntactical changes in order to better reveal any actual changes to test functionality.
1c0bdf2
to
94b2f2c
Compare
5ac6d20
to
606253f
Compare
Intent
Fixes #62
Fixes #78
Approach
For
diseasystore
we have been restructuring the workflows.These workflows are available on https://github.com/ssi-dk/AEF-DDF/
This PR implements these workflows which have improved triggering conditions (fixes #62) and
separated test by DB backend (including SQL sever - fixes #78)
This requires some changes to
setup.R
and the test now draw their connections fromget_test_conns()
A few tests had to be adjusted / removed in this new testing context
Known issues
This PR uses workflows from AEF-DDF that are not yet merged into main
Once merged, this PR should change the source of the workflows to main on AEF-DDF
This PR is based on rc-v0.3 which is not yet merged into main
Once merged, this PR should be rebased to main
Checklist
NEWS.md