Merged
Conversation
4 tasks
f7d011b to
569d877
Compare
dfd8d57 to
1110776
Compare
marcusmunch
approved these changes
Jan 16, 2024
Contributor
marcusmunch
left a comment
There was a problem hiding this comment.
Well, that was a mouthful—especially 0d43c2d.
I suppose that you intended to keep every commit as "complete" as possible, which in turn made the git diff quite hard to grasp. For the future, consider separating the commit into (for lack of better words) functional and syntactical changes in order to better reveal any actual changes to test functionality.
1c0bdf2 to
94b2f2c
Compare
5ac6d20 to
606253f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fixes #62
Fixes #78
Approach
For
diseasystorewe have been restructuring the workflows.These workflows are available on https://github.com/ssi-dk/AEF-DDF/
This PR implements these workflows which have improved triggering conditions (fixes #62) and
separated test by DB backend (including SQL sever - fixes #78)
This requires some changes to
setup.Rand the test now draw their connections fromget_test_conns()A few tests had to be adjusted / removed in this new testing context
Known issues
This PR uses workflows from AEF-DDF that are not yet merged into main
Once merged, this PR should change the source of the workflows to main on AEF-DDF
This PR is based on rc-v0.3 which is not yet merged into main
Once merged, this PR should be rebased to main
Checklist
NEWS.md