Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for test class is too strict #66

Closed
Bananeweizen opened this issue Jun 24, 2022 · 0 comments
Closed

Validation for test class is too strict #66

Bananeweizen opened this issue Jun 24, 2022 · 0 comments

Comments

@Bananeweizen
Copy link
Contributor

The validation looks for test related annotations on public test methods only. However, JUnit 5 no longer requires public test methods, therefore the validation wrongly fails on JUnit 5 test classes that leave away the public keyword.

See https://github.com/ssi-schaefer/lcdsl/blob/master/com.wamas.ide.launching/src/com/wamas/ide/launching/validation/LcDslValidator.xtend#L425 and https://github.com/ssi-schaefer/lcdsl/blob/master/com.wamas.ide.launching/src/com/wamas/ide/launching/validation/LcDslValidator.xtend#L427
@mduft mduft closed this as completed in edf86da Jun 27, 2022
mduft added a commit that referenced this issue Jun 27, 2022
@mduft
Merge pull request #69 from Bananeweizen/allow_non_public_test_methods
2c2e175 
Don't check test methods to be public - fixes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bananeweizen