Skip to content

Commit

Permalink
Change the minimum manufacturer ID to 1, per the spec
Browse files Browse the repository at this point in the history
See: https://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php

"Note that while ANSI E1.11, which defines the Manufacturer ID as a
16-bit value in clause D5.12, does not restrict the range, for use
with ANSI E1.20, the ID range is restricted to 0001h through 7FFFh.
The range of 8000h and above is used in ANSI E1.33 for dynamic UIDs."

For now, keeping values 8000h and above in the range. Also, note that
none of the examples will validate because they all use ID zero.
  • Loading branch information
ssilverman committed Sep 25, 2021
1 parent ec82f0a commit 322f3c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rdm-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"title": "Manufacturer ID",
"description": "The manufacturer ID.",
"type": "integer",
"minimum": 0,
"minimum": 1,
"maximum": 65535
},
"pid": {
Expand Down

1 comment on commit 322f3c5

@peternewman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments/opinion on this in #12 .

Please sign in to comment.