Fix up the uproot getting started #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.15% // Head: 91.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #486 +/- ##
========================================
Coverage 91.15% 91.15%
========================================
Files 11 11
Lines 226 226
Branches 6 6
========================================
Hits 206 206
Misses 16 16
Partials 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gordonwatts
added
bug
| import awkward as ak | ||
|
|
||
| dataset_name = [ | ||
| "https://xrootd-local.unl.edu:1094//store/user/AGC/nanoAOD/nanoaod15.root" |
There was a problem hiding this comment.
While I am not aware of any intention of moving this file, I am wondering whether in the longer term it would be safer to use scikit-hep-testdata (or an IRIS-HEP version of such a repository). A potential issue of the file disappearing would be alleviated by CI of course that could catch it when it happens.
BenGalewsky
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
uprootquery in getting started: