Progress bar changes color on completion and failure #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tend into 3.0_develop_cancel
…change the color.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #397 +/- ##
===============================================
+ Coverage 73.85% 75.19% +1.33%
===============================================
Files 42 30 -12
Lines 2310 1431 -879
===============================================
- Hits 1706 1076 -630
+ Misses 604 355 -249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenGalewsky
reviewed
Jun 14, 2024
| if task.fields.get("bar") == "failure": | ||
| self.columns = [ | ||
| TextColumn("[progress.description]{task.description}"), | ||
| BarColumn(complete_style="rgb(255,0,0)"), |
There was a problem hiding this comment.
Why is this here and different from complete_style="rgb(114,156,31) above?
There was a problem hiding this comment.
And this red color is for when the bar is progressing but some files have failed.
Refactoring DataBinder YAML interfaces
Properly handle transform cancellation. Fix tests
ketan96-m
commented
Jun 24, 2024
| TextColumn("[progress.description]{task.description}"), | ||
| BarColumn(), | ||
| BarColumn(complete_style="rgb(114,156,31)", |
There was a problem hiding this comment.
This is the muted green color when the bar is progressing.
…change the color.
…ontend into progress_bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#382
Description
The current progress bar is green through out the process.
Introduced a muted green color for normal process and added a brighter green color when transform bar and download bar finishes all files.
If the transformation fails prematurely, then the bar changes the color to red.
Normal progress:
Completed progress:
Failed Progress:
Solution:
Created a custom
TransformStatusProgressclass which inherits theProgressfromrich.progress.get_renderables()function is overloaded to update theBarColumn()with theredcolor in case of failed files.Added an if condition inside the
query.py'stransform_status_listenerthat checks that the transform is complete and if there are any failed files and then call the update method for the progress bar.The update method takes a new keyword argument to indicate if transformation is complete or not.
Added subsequent test cases to test this new
get_renderables()function and also edited other test cases to with the newTransformStatusProgress.