A few ideas for tweaks

[petehunt]

This is great! Had a few ideas for improvement.

• TodoListItemComponent could have editing be on props instead of state
• Then in componentDidUpdate() you can only focus if (this.props.editing && !prevProps.editing)
• In general I don't like it when mixins read from props since they can manipulate the public API of a component. So I would move getBackboneObject() to the user of the mixin rather than the mixin itself.

Just a few ideas... this looks great!

[ssorallen]

Thanks for the feedback.

• Since editing is controlled by the user and changes over time, it seems more appropriate as state. Is that incorrect thinking? Are there performance differences for state vs. props?
• Good point about the Backbone Mixin. I will change that and have the target object implement either getModel or getCollection.

[petehunt]

Right, I would just move the state to the owner component and have It take the value of the id of the item being edited (or null)

[ssorallen]

Gotcha. I'll try that out.

[ssorallen]

@petehunt I looked at your suggestion again and am wondering what advantage moving editing to a prop offers. Is that because only one item can be in edit mode at once, and so the list should own that state?

[petehunt]

exactly