Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Linode API v4 #9

Merged
merged 28 commits into from
Aug 1, 2022
Merged

Switch to Linode API v4 #9

merged 28 commits into from
Aug 1, 2022

Conversation

testeddoughnut
Copy link
Contributor

Howdy! This is a major update to switch this project to use Linode API v4. As well, it modernizes the code to follow patterns in other upstream kitchen drivers, including switching to chefstyle instead of using rubocop directly and bumping all dependencies. A more comprehensive list of changes follows:

  • Switch from fog to fog-linode to switch to Linode API v4.
  • Add API retry support to retry calls on timeouts or rate-limits.
  • Bumped all dependencies to what the upstream plugins are using.
  • Switch to using chefstyle so we don't have to managed our own rubocop config.
  • Added support for most APIv4 options for Linode Create.
  • Dropped some options (kernel, for example) that aren't supported on the create call.
  • Added additional environment variable support for options where it made sense.
  • Removed all the API calls to validate image, region, kernel etc since the create call does that for us.
  • Added better error reporting for when the create call runs into trouble.
  • Added checks around label generation to avoid creating an instance with a duplicate label.
  • Improved support for the post-build steps to set hostname and disable password login.
    • It now works for all base images that Linode offers, including the less popular ones.
    • It also now disables password login through SSH config instead of just locking the account.
  • Added a .kitchen.yml file to test all base images. This is not added to the CI at this time.
  • Updated all tests to be more comprehensive and to simulate the API calls with webmock.
  • Updated README to cover all the new options and features.

stvnjacobs and others added 28 commits April 16, 2021 23:28
@stvnjacobs
replace fog with fog-linode
df17a2c
@stvnjacobs
replace data_center with region
ce0f3ed
@stvnjacobs
replace flavor with type
6cf1cd0
@stvnjacobs
update kernel configuration
8be0497
@stvnjacobs
update image configuration
b39880d
@stvnjacobs
remove payment_terms configuration
81155c8
@stvnjacobs
replace server_name with label
ef24e7e
@stvnjacobs
provide only id for configs to server create
c3b0023 
There were type errors when providing the object. This is a change from
the previous fog linode provider.
@stvnjacobs
[wip] fog-linode tweaks to make it work
0c28014
@stvnjacobs
add hostname config seperate from label
00ffaa2
@stvnjacobs
default image to instance name
d0d710b
@stvnjacobs
Revert "default image to instance name"
58f89a4 
This reverts commit d0d710b.
@stvnjacobs
feat: use instance name if found
b51241f
@testeddoughnut
Retry API requests on timeouts (HTTP status 408)
9282f27 
This just wraps the API calls in a retry when the API returns a
408. By default it retries 3 times, that can be adjusted using
the `api_retries` config option.

Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Print message on create failure
f4aebee 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Better unique label generation
5a02229 
Now the code will check if another server is already using the
label is wants, and if so it'll pick a different random suffix.

Added retry support if we do end up with a non-unique label
on server create.

Added better error handling on deletes so a 404 doesn't make
it nervous.

Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Retry on rate limits too
c37a9a1 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@stvnjacobs
Merge pull request stvnjacobs#2 from testeddoughnut/api-v4-retry
18bd262 
Retry API requests on timeouts (HTTP status 408)
@testeddoughnut
Bump deps and modernize
a1d3501 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Fix style and tests
7e687b4 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Bump ci ruby tests
f1a89b2 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Update readme and some test fixes
2724f0f 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Drop required column in readme
764cb7d 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Refactor and adding additional API features
aec5a38 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Update readme, add kitchen.yml
92d2118 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Finish out tests
773faf5 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
fix tests in github runner
ee7cdc7 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Update readme
64cb08a 
Signed-off-by: M. David Bennett <mdavidbennett@syntheticworks.com>
@testeddoughnut
Copy link
Contributor Author

@ssplatt is this project still being maintained?

@ssplatt ssplatt merged commit 68f5e9e into ssplatt:master Aug 1, 2022
This was referenced Aug 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@testeddoughnut @ssplatt @stvnjacobs