Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform<T> functions explicitly return undefined #423

Merged
merged 1 commit into from
May 29, 2024
Merged

Transform<T> functions explicitly return undefined #423

merged 1 commit into from
May 29, 2024

Conversation

ravenscar
Copy link
Contributor

addresses #422

@ravenscar ravenscar mentioned this pull request May 16, 2024
Closed
@tallowen
Copy link

cc @fwang - since it looks like you intentionally introduced the behavior change in e7f039a.

Having landed had this typecheck landed would have saved me a lot of time debugging!

@jayair
Copy link
Contributor

jayair commented May 20, 2024

I'll ask Frank to review.

@fwang fwang merged commit 2e78ed9 into sst:dev May 29, 2024
@fwang
Copy link
Contributor

fwang commented May 29, 2024

Thanks @ravenscar @tallowen! The fix will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ravenscar @tallowen @jayair @fwang