fix: missing html files for non blocking fallback page (#152)

* fix: missing html files for non blocking fallback page * Sync --------- Co-authored-by: Frank <wangfanjie@gmail.com>
sst · Jul 4, 2023 · a468add · a468add · vercel · Jul 4, 2023
1 parent f40854b
commit a468add
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/clever-waves-know.md b/.changeset/clever-waves-know.md
@@ -0,0 +1,5 @@
+---
+"open-next": patch
+---
+
+Fix missing HTML files for non blocking fallback pages
diff --git a/packages/open-next/src/build.ts b/packages/open-next/src/build.ts
@@ -497,6 +497,7 @@ function addPublicFilesList(outputPath: string, packagePath: string) {
 function removeCachedPages(outputPath: string, packagePath: string) {
   // Pre-rendered pages will be served out from S3 by the cache handler
   const dotNextPath = path.join(outputPath, packagePath);
+  const isFallbackTruePage = /\[.*\]/;
   const htmlPages = getHtmlPages(dotNextPath);
   [".next/server/pages", ".next/server/app"]
     .map((dir) => path.join(dotNextPath, dir))
@@ -508,7 +509,12 @@ function removeCachedPages(outputPath: string, packagePath: string) {
           file.endsWith(".json") ||
           file.endsWith(".rsc") ||
           file.endsWith(".meta") ||
-          (file.endsWith(".html") && !htmlPages.has(file))
+          (file.endsWith(".html") &&
+            // do not remove static HTML files
+            !htmlPages.has(file) &&
+            // do not remove HTML files with "[param].html" format
+            // b/c they are used for "fallback:true" pages
+            !isFallbackTruePage.test(file))
       )
     );
 }