docs: add documentation on minimizing lambda bundle #167

khuezy · 2023-07-29T17:05:51Z

fixes: #166

Edit: one of the changes breaks server actions 😢
We might be better off removing the dev modules inside build.ts...

changeset-bot · 2023-07-29T17:05:54Z

⚠️ No Changeset found

Latest commit: 876be70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-07-29T17:05:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 12, 2023 5:44pm

jayair · 2023-08-02T23:53:24Z

Do we want to merge this @khuezy?

khuezy · 2023-08-03T00:02:33Z

Yes, I added a note on server actions. Feel free to edit and merge.

JanStevens · 2023-08-25T10:55:47Z

FYI im using the following list:

'./node_modules/@next/swc-darwin-x64',
'./node_modules/@next/swc-linux-arm64-gnu',
'./node_modules/@next/swc-linux-arm64-musl',
'./node_modules/@next/swc-linux-x64-gnu',
'./node_modules/@next/swc-linux-x64-musl',
'./node_modules/@next/swc-win32-arm64-msvc',
'./node_modules/@next/swc-win32-ia32-msvc',
'./node_modules/@next/swc-win32-x64-msvc',
'./node_modules/@swc/core-linux-x64-gnu',
'./node_modules/@swc/core-linux-x64-musl',
'./node_modules/@swc/core-linux-x64-gnux32',
'./node_modules/caniuse-lite',
'./node_modules/uglify-js',
'./node_modules/watchpack',
'./node_modules/@esbuild',
'./node_modules/@rollup',
'./node_modules/@webassemblyjs',
'./node_modules/esbuild/linux',
'./node_modules/rollup',
'./node_modules/terser',

khuezy · 2023-08-25T18:49:46Z

Thanks @JanStevens , I'll put up a PR to remove those at buildtime. Since this isn't a blocker though, I'll defer this until after the other PRs.

Actually this is the PR... I'll update it later.

khuezy · 2023-10-12T16:38:28Z

@conico974 PTAL

conico974

LGTM, i've added some comments, but they're not strictly necessary.

It's only webpack that we need for server actions right ?

conico974 · 2023-10-12T16:49:38Z

docs/pages/common_issues/bundle_size.mdx

+        'esbuild',
+        'uglify-js',
+        'watchpack',
+        'webassemblyjs'


We could probably add sharp here, people might have installed but it's not needed outside of the image optimization function.
We should probably add a comment to explain it

conico974 · 2023-10-12T17:03:22Z

docs/pages/common_issues/bundle_size.mdx

+
+#### Reducing Bundle Size
+
+Next will incorrectly trace dev dependencies to be included in the output `node_modules`, which will significantly increase the lambda bundle. For example, the @swc/core-\* binary is ~33MB!


With 13.5.1+ they probably will not even end up in node_modules, a big part is now bundled by next and may end up in one of the bundle

I built w/ 13.5.4 and the core-darwin-arm64 binary was still there unfortunately

conico974 · 2023-10-12T17:07:38Z

docs/pages/common_issues.mdx

+#### Unzipped size must be smaller than 262144000 bytes
+
+AWS Lambda has an unzipped size limit of 250MB. If your app is over this limit, then it is most likely using a node_module library that is too large for serverless or there is a large dev dependency getting bundled.


Maybe add that what's important is the .open-next/server-function folder, and the rest are mostly irrelevant.
We could also add that a big bundle size will increase cold start a lot

khuezy · 2023-10-12T17:21:54Z

LGTM, i've added some comments, but they're not strictly necessary.

It's only webpack that we need for server actions right ?

As far as I know but it's been awhile since I tested (13.3 I think).

seed-deploy bot had a problem deploying to pr167 July 29, 2023 17:05 Failure

vercel bot deployed to Preview July 29, 2023 17:06 View deployment

khuezy force-pushed the docs/bundle branch from 1b15b11 to c4aa453 Compare July 29, 2023 17:11

seed-deploy bot had a problem deploying to pr167 July 29, 2023 17:11 Failure

vercel bot deployed to Preview July 29, 2023 17:12 View deployment

seed-deploy bot had a problem deploying to pr167 July 29, 2023 18:15 Failure

vercel bot deployed to Preview July 29, 2023 18:16 View deployment

seed-deploy bot temporarily deployed to pr167 August 3, 2023 00:02 Inactive

vercel bot deployed to Preview August 3, 2023 00:03 View deployment

update docs

54a150b

khuezy force-pushed the docs/bundle branch from d8a0d4e to 54a150b Compare October 12, 2023 16:32

vercel bot deployed to Preview October 12, 2023 16:33 View deployment

khuezy requested a review from conico974 October 12, 2023 16:38

conico974 approved these changes Oct 12, 2023

View reviewed changes

add e2e test instructions

267eabd

vercel bot deployed to Preview October 12, 2023 17:21 View deployment

updated docs with details about sharp and pdfjs

876be70

vercel bot deployed to Preview October 12, 2023 17:44 View deployment

khuezy merged commit d291e6a into sst:main Oct 12, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add documentation on minimizing lambda bundle #167

docs: add documentation on minimizing lambda bundle #167

khuezy commented Jul 29, 2023 •

edited

Loading

changeset-bot bot commented Jul 29, 2023 •

edited

Loading

vercel bot commented Jul 29, 2023 •

edited

Loading

jayair commented Aug 2, 2023

khuezy commented Aug 3, 2023

JanStevens commented Aug 25, 2023 •

edited

Loading

khuezy commented Aug 25, 2023 •

edited

Loading

khuezy commented Oct 12, 2023

conico974 left a comment

conico974 Oct 12, 2023

conico974 Oct 12, 2023

khuezy Oct 12, 2023

conico974 Oct 12, 2023

khuezy commented Oct 12, 2023


		#### Reducing Bundle Size

		Next will incorrectly trace dev dependencies to be included in the output `node_modules`, which will significantly increase the lambda bundle. For example, the @swc/core-\* binary is ~33MB!

		#### Unzipped size must be smaller than 262144000 bytes

		AWS Lambda has an unzipped size limit of 250MB. If your app is over this limit, then it is most likely using a node_module library that is too large for serverless or there is a large dev dependency getting bundled.

docs: add documentation on minimizing lambda bundle #167

docs: add documentation on minimizing lambda bundle #167

Conversation

khuezy commented Jul 29, 2023 • edited Loading

changeset-bot bot commented Jul 29, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Jul 29, 2023 • edited Loading

jayair commented Aug 2, 2023

khuezy commented Aug 3, 2023

JanStevens commented Aug 25, 2023 • edited Loading

khuezy commented Aug 25, 2023 • edited Loading

khuezy commented Oct 12, 2023

conico974 left a comment

Choose a reason for hiding this comment

conico974 Oct 12, 2023

Choose a reason for hiding this comment

conico974 Oct 12, 2023

Choose a reason for hiding this comment

khuezy Oct 12, 2023

Choose a reason for hiding this comment

conico974 Oct 12, 2023

Choose a reason for hiding this comment

khuezy commented Oct 12, 2023

khuezy commented Jul 29, 2023 •

edited

Loading

changeset-bot bot commented Jul 29, 2023 •

edited

Loading

vercel bot commented Jul 29, 2023 •

edited

Loading

JanStevens commented Aug 25, 2023 •

edited

Loading

khuezy commented Aug 25, 2023 •

edited

Loading