Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error on Windows that SHARP_IGNORE_GLOBAL_LIBVIPS is not reco… #219

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

aatta
Copy link
Contributor

@aatta aatta commented Sep 7, 2023

Fix for error on Windows that SHARP_IGNORE_GLOBAL_LIBVIPS is not recognized as n internal or external command.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 9480950

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 7:37am

@khuezy
Copy link
Collaborator

khuezy commented Sep 8, 2023

hi @aatta thanks for the PR! Can you run npm run lint:fix to format the style to get the validator to pass? Thanks!

@aatta
Copy link
Contributor Author

aatta commented Sep 8, 2023

hi @aatta thanks for the PR! Can you run npm run lint:fix to format the style to get the validator to pass? Thanks!

Done, please check now.

@khuezy
Copy link
Collaborator

khuezy commented Sep 8, 2023

Thanks! This will go in 2.1.2 with 2 other bug fixes.

@khuezy khuezy merged commit 947fe4d into sst:main Sep 8, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
@sladg
Copy link
Contributor

sladg commented Sep 11, 2023

Heya, was there a reason to not go with following syntax?

execSync('.... sharp command ....', {
    env: {
      SHARP_IGNORE_GLOBAL_LIBVIPS: '1',
    },
  })

cp.execSync has possibility to set envs inside. I would imagine this working cross platform :)

@khuezy @aatta

@khuezy
Copy link
Collaborator

khuezy commented Sep 13, 2023

@aatta Are you able to build the image optimization w/ the set command? I know on windows, that's how you set the env variable, but some people are getting errors now :/

@khuezy
Copy link
Collaborator

khuezy commented Sep 13, 2023

@sladg I'm not able to get that to work on my machine. The image does not get optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants