Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags cache #317

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Fix tags cache #317

merged 5 commits into from
Nov 28, 2023

Conversation

conico974
Copy link
Collaborator

This PR should fixes 2 issues from using revalidateTag

  • A regression was introduced in Perf Reduce s3 calls #295 which made tags not being generated at build time for any route
  • fetch cache is never read on next@14+, they changed the interface again

This PR also adds a test for revalidateTag

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: b2d53e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch
tests-unit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ❌ Failed (Inspect) Nov 28, 2023 9:28pm

@sladg
Copy link
Contributor

sladg commented Nov 19, 2023

Considering no change in package.json in lock file update correct/expect?

@conico974
Copy link
Collaborator Author

Considering no change in package.json in lock file update correct/expect?

Yes and no, I had to update next for the e2e tests.
I'll push a change to pin next to 14.0.3 in package.json, we already install latest during e2e so it's fine

@conico974 conico974 merged commit abeb9cd into opennextjs:main Nov 28, 2023
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants