Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lambda streaming on empty body #443

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

conico974
Copy link
Collaborator

@conico974 conico974 commented Jun 14, 2024

This PR add an env variable OPEN_NEXT_FORCE_NON_EMPTY_RESPONSE, when set to true it will force writing something to the stream.

This should only be used with lambda streaming AND if you have issues with the stream hanging on empty body response (i.e. HEAD request, redirect...). See this discord thread
You should avoid using this as much as you can, because it modifies the response you send ( It might break some very specific cases )

It is disabled by default.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 3e73c4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 9:40am

@conico974 conico974 merged commit 6032493 into sst:main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant