Merge pull request #3 from sstalle/bitwise-shift-checks

Added bitwise shift checks

src/Infrastructure/ContainerBuilder.php

@@ -29,6 +29,7 @@ class ContainerBuilder
         'visitor.hexadecimalNumberString' => '\\Sstalle\\php7cc\\NodeVisitor\\HexadecimalNumberStringVisitor',
         'visitor.escapedUnicodeCodepoint' => '\\Sstalle\\php7cc\\NodeVisitor\\EscapedUnicodeCodepointVisitor',
         'visitor.arrayOrObjectValueAssignmentByReference' => '\\Sstalle\\php7cc\\NodeVisitor\\ArrayOrObjectValueAssignmentByReferenceVisitor',
+        'visitor.bitwiseShift' => '\\Sstalle\\php7cc\\NodeVisitor\\BitwiseShiftVisitor',
     );
 
     /**

src/NodeVisitor/BitwiseShiftVisitor.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace Sstalle\php7cc\NodeVisitor;
+
+use PhpParser\Node;
+
+class BitwiseShiftVisitor extends AbstractVisitor
+{
+
+    const MIN_INT_SIZE = 32;
+
+    public function enterNode(Node $node)
+    {
+        $isLeftShift = $node instanceof Node\Expr\BinaryOp\ShiftLeft;
+        $isRightShift = $node instanceof Node\Expr\BinaryOp\ShiftRight;
+        if (!$isLeftShift && !$isRightShift) {
+            return;
+        }
+
+        $rightOperand = $node->right;
+        if ($rightOperand instanceof Node\Expr\UnaryMinus && $rightOperand->expr instanceof Node\Scalar\LNumber
+            && $rightOperand->expr->value > 0
+        ) {
+            $this->addContextMessage(
+                'Bitwise shift by a negative number',
+                $node
+            );
+        } elseif ($rightOperand instanceof Node\Scalar\LNumber && $rightOperand->value >= static::MIN_INT_SIZE) {
+            $this->addContextMessage(
+                sprintf('Bitwise shift by %d bits', $rightOperand->value),
+                $node
+            );
+        }
+    }
+
+}

test/code/ContextCheckerTest.php

@@ -34,6 +34,7 @@ public function testMessages($name, $code, $expectedMessages)
             '\\Sstalle\\php7cc\\NodeVisitor\\HexadecimalNumberStringVisitor',
             '\\Sstalle\\php7cc\\NodeVisitor\\EscapedUnicodeCodepointVisitor',
             '\\Sstalle\\php7cc\\NodeVisitor\\ArrayOrObjectValueAssignmentByReferenceVisitor',
+            '\\Sstalle\\php7cc\\NodeVisitor\\BitwiseShiftVisitor',
              ) as $visitorClass) {
             $traverser->addVisitor(new $visitorClass());
         }

test/resource/bitwiseShift/bitwiseShiftByNegativeBinaryNumber.test

@@ -0,0 +1,25 @@
+Bitwise shift by a negative binary number
+-----
+<?php $a >> -0b10;
+-----
+Bitwise shift by a negative number
+-----
+<?php 1 << -0b10;
+-----
+Bitwise shift by a negative number
+-----
+<?php $a >> 0b0;
+-----
+
+-----
+<?php 1 << 0b0;
+-----
+
+-----
+<?php $a >> 0b1010;
+-----
+
+-----
+<?php 1 << 0b1010;
+-----
+

test/resource/bitwiseShift/bitwiseShiftByNegativeDecimalNumber.test

@@ -0,0 +1,25 @@
+Bitwise shift by a negative decimal number
+-----
+<?php $a >> -2;
+-----
+Bitwise shift by a negative number
+-----
+<?php 1 << -2;
+-----
+Bitwise shift by a negative number
+-----
+<?php $a >> 0;
+-----
+
+-----
+<?php 1 << 0;
+-----
+
+-----
+<?php $a >> 10;
+-----
+
+-----
+<?php 1 << 10;
+-----
+

test/resource/bitwiseShift/bitwiseShiftByNegativeHexadecimalNumber.test

@@ -0,0 +1,25 @@
+Bitwise shift by a negative hexadecimal number
+-----
+<?php $a >> -0x2;
+-----
+Bitwise shift by a negative number
+-----
+<?php 1 << -0x2;
+-----
+Bitwise shift by a negative number
+-----
+<?php $a >> 0x0;
+-----
+
+-----
+<?php 1 << 0x0;
+-----
+
+-----
+<?php $a >> 0xa;
+-----
+
+-----
+<?php 1 << 0xa;
+-----
+

test/resource/bitwiseShift/bitwiseShiftByNegativeOctalNumber.test

@@ -0,0 +1,25 @@
+Bitwise shift by a negative octal number
+-----
+<?php $a >> -02;
+-----
+Bitwise shift by a negative number
+-----
+<?php 1 << -02;
+-----
+Bitwise shift by a negative number
+-----
+<?php $a >> 00;
+-----
+
+-----
+<?php 1 << 00;
+-----
+
+-----
+<?php $a >> 012;
+-----
+
+-----
+<?php 1 << 012;
+-----
+

test/resource/bitwiseShift/bitwiseShiftLargerThanIntWidthBinary.test

@@ -0,0 +1,25 @@
+Bitwise shift by a binary number of bits greater or equal to minimum int size constant
+-----
+<?php $a >> 0b100000;
+-----
+Bitwise shift by 32 bits
+-----
+<?php 1 << 0b100000;
+-----
+Bitwise shift by 32 bits
+-----
+<?php $a >> 0b1000000;
+-----
+Bitwise shift by 64 bits
+-----
+<?php 1 << 0b1000000;
+-----
+Bitwise shift by 64 bits
+-----
+<?php $a >> 0b10000;
+-----
+
+-----
+<?php 1 << 0b10000;
+-----
+

test/resource/bitwiseShift/bitwiseShiftLargerThanIntWidthDecimal.test

@@ -0,0 +1,24 @@
+Bitwise shift by a decimal number of bits greater or equal to minimum int size constant
+-----
+<?php $a >> 32;
+-----
+Bitwise shift by 32 bits
+-----
+<?php 1 << 32;
+-----
+Bitwise shift by 32 bits
+-----
+<?php $a >> 64;
+-----
+Bitwise shift by 64 bits
+-----
+<?php 1 << 64;
+-----
+Bitwise shift by 64 bits
+-----
+<?php $a >> 16;
+-----
+
+-----
+<?php 1 << 16;
+-----

test/resource/bitwiseShift/bitwiseShiftLargerThanIntWidthHexadecimal.test

@@ -0,0 +1,25 @@
+Bitwise shift by a hexadecimal number of bits greater or equal to minimum int size constant
+-----
+<?php $a >> 0x20;
+-----
+Bitwise shift by 32 bits
+-----
+<?php 1 << 0x20;
+-----
+Bitwise shift by 32 bits
+-----
+<?php $a >> 0x40;
+-----
+Bitwise shift by 64 bits
+-----
+<?php 1 << 0x40;
+-----
+Bitwise shift by 64 bits
+-----
+<?php $a >> 0x10;
+-----
+
+-----
+<?php 1 << 0x10;
+-----
+

test/resource/bitwiseShift/bitwiseShiftLargerThanIntWidthOctal.test

@@ -0,0 +1,24 @@
+Bitwise shift by an octal number of bits greater or equal to minimum int size constant
+-----
+<?php $a >> 040;
+-----
+Bitwise shift by 32 bits
+-----
+<?php 1 << 040;
+-----
+Bitwise shift by 32 bits
+-----
+<?php $a >> 0100;
+-----
+Bitwise shift by 64 bits
+-----
+<?php 1 << 0100;
+-----
+Bitwise shift by 64 bits
+-----
+<?php $a >> 020;
+-----
+
+-----
+<?php 1 << 020;
+-----