Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pre-commit hook installation #7

Closed
sstallion opened this issue May 5, 2021 · 4 comments
Closed

Simplify pre-commit hook installation #7

sstallion opened this issue May 5, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@sstallion
Copy link
Owner

A command should be added to simplify installing scripts/pre-commit.sh to wikis managed by git.

@sstallion sstallion added the enhancement New feature or request label May 5, 2021
jfishe added a commit to jfishe/vimwiki-cli that referenced this issue Feb 11, 2024
@sstallion
Copy link
Owner Author

Fixed by @jfishe in #14.

@jfishe
Copy link
Contributor

jfishe commented Feb 16, 2024

If you want to see the messages from the pre-commit hook, e.g:

vim|wiki: Generating links...done.
vim|wiki: Generating diary links...done.
vim|wiki: Rebuilding tag metadata...done.
vim|wiki: Generating tag links...done.
vim|wiki: Converting all wiki pages to HTML...done.

Add verbose: true in .pre-commit-config.yaml:

repos:
    - repo: https://github.com/sstallion/vimwiki-cli
    rev: v1.2.0
    hooks:
      - id: vimwiki-cli
        verbose: true

@sstallion
Copy link
Owner Author

sstallion commented Feb 17, 2024

@jfishe I wonder if this should be the default. Worst case, we could add a verbose option in pre-commit.sh if someone wants to silence those messages.

@jfishe
Copy link
Contributor

jfishe commented Feb 18, 2024

@jfishe I wonder if this should be the default. Worst case, we could add a verbose option in pre-commit.sh if someone wants to silence those messages.

I'm ok either way; I have it turned on for now--I may tire of the verbosity later. Pre-commit tends to avoid opt-out defaults.

We could change the example in the README to make it more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants