Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric value question #76

Closed
gminiba opened this issue Jan 27, 2022 · 3 comments
Closed

Metric value question #76

gminiba opened this issue Jan 27, 2022 · 3 comments

Comments

@gminiba
Copy link
Contributor

gminiba commented Jan 27, 2022

Hi!
What is this * 1000 for? https://github.com/sstarcher/helm-exporter/blob/master/main.go#L150
I'm using the metric value to compare it with time() in Prometheus and cannot get the reason it's multiplied by 1000 in the exporter.
If you don't mind I want to create a PR to make it possible to get the metric without this multiplication with the optional parameter. The default behavior is not to change.

@sstarcher
Copy link
Owner

sstarcher commented Jan 27, 2022 via email

@gminiba
Copy link
Contributor Author

gminiba commented Jan 27, 2022

Sure I can, but it looks strange to me

@sstarcher
Copy link
Owner

This was the original request as Grafana looks to use the default format of milliseconds - #10

So they have the opposite issue that you have. It's not going to be possible to make every tool happy. Luckily Prometheus can support multiplication, but Grafana does not support changing the format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants