Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

skip cuts comment after closing bracket #240

Closed
and0x000 opened this issue Nov 14, 2017 · 1 comment
Closed

skip cuts comment after closing bracket #240

and0x000 opened this issue Nov 14, 2017 · 1 comment

Comments

@and0x000
Copy link

If I use a regular bracket in the comment of the "skip" command, everything after that bracket is dropped.

Example:
setup(){ skip "foo)bar" }
@test "skip this" { echo 'asdf' }

Expected Output:

  • skip this (skipped: foo)bar)

Actual Output:

  • skip this (skipped: foo)

Does not matter if I use single or double quotes for the comment.

Tested with bats from debian repo:
https://packages.debian.org/stretch/bats

cdevinesr added a commit to cdevinesr/bats-core that referenced this issue Dec 20, 2017
Addresses sstephenson/bats#240.  When outputting a 'pretty' formatted
output stream, the 'skip' message was being processed with a character
class of [^)].  I couldn't find a reason for this to be the case, so
I've swapped it out to check instead of printable characters, spaces
included ([:print:]).  Please advise if there is a problem with this
approach.

Tested using Bash 4.3.11(1)-release.
cdevinesr added a commit to cdevinesr/bats-core that referenced this issue Jun 13, 2018
This test case checks whether skipped tests with closing parentheses are
formatted correctly when passed throguh the pretty formatter.
@and0x000
Copy link
Author

supposed to be resolved with bats-core/bats-core#48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant