Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JRuby 1.7.x #162

Merged
merged 2 commits into from
May 24, 2012
Merged

Update JRuby 1.7.x #162

merged 2 commits into from
May 24, 2012

Conversation

abscondment
Copy link
Contributor

  • Remove -dev build, since it no longer exists on ci.jruby.org
  • Add 1.7.0.preview1

 * Remove -dev build, since it no longer exists on ci.jruby.org
 * Add 1.7.0.preview1
@jeremy
Copy link
Member

jeremy commented May 21, 2012

Could you use a hyphen to match the ruby-build convention? jruby-1.7.0-preview1

Shame that the -dev tarball is gone. That forces people using it to upgrade. Better to point the definition at a new, working URL than remove it entirely.

@abscondment
Copy link
Contributor Author

I tried to use that name initially, but the tarball itself is listed as 1.7.0.preview1. Changing the package name breaks the installation since the tarball contains a directory with the old, alternate name.

I also looked for a new dev URL, but couldn't figure out a good replacement.

What do you suggest regarding the naming convention? I don't have any input into the JRuby releases, and it seems the scripts aren't set up to allow the package_name to differ from the tarball's contents.

@abscondment
Copy link
Contributor Author

Actually, I take it back -- it looks like changing the file name but not the package name produces the desired result.

@jeremy
Copy link
Member

jeremy commented May 22, 2012

Check out the -dev package. You can use a hyphen in the package name -- for both the filename and for install_package -- independently of the tarball's filename.

@abscondment
Copy link
Contributor Author

So, does anything need to change after 7f574db? If I hyphenate the package name in the install_package call, it produces the cd issue I referred to.

sstephenson added a commit that referenced this pull request May 24, 2012
@sstephenson sstephenson merged commit 46cb81c into rbenv:master May 24, 2012
@sstephenson
Copy link
Contributor

Looks good - thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants