Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early dection of mispelled port name does not work with 2x2 mulit- on El Capitan #213

Closed
jpvandy opened this issue Apr 5, 2017 · 2 comments
Assignees

Comments

@jpvandy
Copy link
Contributor

jpvandy commented Apr 5, 2017

A long time ago processing was insert to induce an early seg-fault if a port name was misspelled. (This was protection against this error being encounter later in a less obvious way.) Also a test was created to verify the non-matching port was thusly detected.
Currently a bad port name does not induce a seg-fault on 2x2 multi on El Capitan.
It is not clear when a code update removed this failure, because until quite recently 2x2 on all platforms had so test failures that this low priority error wasn't noticed.

@ghost
Copy link

ghost commented Apr 11, 2017

I do not recall ever forcing a segfault in the code. The ConfigGraph's checkForStructuralErrors should be printing a warning about invalid ports. I would be OK upgrading that warning to a Output.fatal() call.

Thoughts? ( @nmhamster @feldergast )

@nmhamster
Copy link
Contributor

@bjmoor definitely would prefer an Output.fatal() call because that should handle cleanup correctly with respect to MPI etc.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants