Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Keyword Warnings produced from Event API #274

Closed
nmhamster opened this issue Jun 26, 2017 · 3 comments
Closed

Override Keyword Warnings produced from Event API #274

nmhamster opened this issue Jun 26, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@nmhamster
Copy link
Contributor

In file included from membackend/cramSimBackend.cc:21:
../../../../src/sst/elements/CramSim/memReqEvent.hpp:53:10: warning: 'serialize_order' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void serialize_order(SST::Core::Serialization::serializer &ser) {
         ^
/Users/sdhammo/Documents/SST/20170623/core/include/sst/core/event.h:184:10: note: overridden virtual function is here
    void serialize_order(SST::Core::Serialization::serializer &ser) override{
         ^
In file included from membackend/cramSimBackend.cc:21:
../../../../src/sst/elements/CramSim/memReqEvent.hpp:88:10: warning: 'serialize_order' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void serialize_order(SST::Core::Serialization::serializer &ser) {
         ^
/Users/sdhammo/Documents/SST/20170623/core/include/sst/core/event.h:184:10: note: overridden virtual function is here
    void serialize_order(SST::Core::Serialization::serializer &ser) override{
@ghost
Copy link

ghost commented Jun 29, 2017

Isn't this actually an issue that CramSim is not properly using the 'override' keyword?

@allevin allevin modified the milestones: SST v7.2.0, Future Mar 4, 2020
@allevin
Copy link
Contributor

allevin commented Mar 4, 2020

@feldergast is this fixed?

@feldergast
Copy link
Contributor

This was "fixed" in CramSim. They simply added:

#pragma clang diagnostic ignored "-Winconsistent-missing-override"

to the effected file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants