Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemHierarchy should not segfault on misaligned loads #700

Closed
ghost opened this issue Jul 16, 2017 · 4 comments
Closed

MemHierarchy should not segfault on misaligned loads #700

ghost opened this issue Jul 16, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 16, 2017

L1CoherenceController can segfault when the cache receives a request that spans across cache lines. It would be nicer to Output.fatal() with such a message, rather than segfault.

@nmhamster
Copy link
Contributor

@bjmoor @gvoskuilen - I think this depends on the contract with the processor core people. If the requirement is that the core ensures no unaligned/split requests then its OK to not have this checked. It might also be better to not have the checks slowing down the behavior? Thoughts?

@gvoskuilen
Copy link
Contributor

@nmhamster @bjmoor - I think it should be a requirement for the core to ensure no unaligned/split requests. I'd rather avoid an extra check on every access.

@ghost
Copy link
Author

ghost commented Jul 18, 2017

Personally, I think that branch predictors are pretty good, and segfaults are bad. Users should not get a segfault using our code. That puts a significant onus on them how to debug code that isn't theirs, and when I was receiving that segfault, it was FAR from obvious that the reason was mis-aligned cache accesses.

@allevin
Copy link
Contributor

allevin commented Oct 14, 2020

Fixed if user turns on debug.

@allevin allevin closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants