Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple inlineStyles to be returned by customInlineFn #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow multiple inlineStyles to be returned by customInlineFn #155

wants to merge 2 commits into from

Conversation

betancourtl
Copy link

@betancourtl betancourtl commented Dec 22, 2018

What does this PR do?

Previously the customStyleFn only allowed you to apply a single style. This PR improves the behavior of the customInlineStyleFn by allowing it to return multiple inlineStyles so they can be applied to an an element.

Does it break anything?

This addition would enhance the functionality of the customStyleFn in a backwards compatible way.

Does it have tests?

Yes!

Who would benefit from this?

Here are several issues open that this functionality fixes.

  1. Add ability to handle multiple styles in customInlineFn of stateFromHTML #142
  2. Returning multiple styles from customInlineFn? #154
  3. Instantiate EditorState from HTML betancourtl/draft-js-custom-styles#2
  4. Add support for multiple custom styles, separated by a space #136

I would love to have this merged. Please let me know your thoughts.

@entryone
Copy link

it is a very useful feature. I look forward to the release

@tylde
Copy link

tylde commented May 31, 2019

When can we expect the release with this change?

Amwam added a commit to wegotpop/draft-js-utils that referenced this pull request Jul 4, 2019
@mitchellwarr
Copy link

Whats the status on this?

@steveostudios
Copy link

Any idea on if this will get merged? I would LOVE this functionality!

@dobosmarton
Copy link

When would you like to merge this PR, any idea? It would be really useful.

@mitchellwarr
Copy link

It has been over a year since this PR was proposed, any word on why it hasn't been merged would be appreciated. Does it need more work? Are the maintainers just swamped? The bug this PR solves is a major painpoint, so a comment of any kind would be helpful

asleepwalker pushed a commit to ShelterzoomCorp/draft-js-utils that referenced this pull request May 19, 2020
@iam-medvedev
Copy link

Any updates on this?

@msk-psp
Copy link

msk-psp commented Jul 29, 2020

@webdeveloperpr Hello, did you found any substitution module that convert to HTML and convert from HTML ? Your fork was removed

msk-psp added a commit to msk-psp/draft-js-utils that referenced this pull request Jul 29, 2020
msk-psp added a commit to msk-psp/draft-js-utils that referenced this pull request Jul 29, 2020
Allow multiple inlineStyles to be returned by customInlineFn sstur#155
@greenxiii
Copy link

Are there any updates?

@kimhou
Copy link

kimhou commented Sep 30, 2021

waiting for update...

@timuster
Copy link

timuster commented Jan 9, 2022

@orenaksakal @entryone Any ideas on when this will get merged? It has been more than 3 years now.

swissspidy added a commit to swissspidy/draft-js-import-element that referenced this pull request Feb 28, 2022
Contains changes from sstur/draft-js-utils#155 to allow multiple inlineStyles to be returned by `customInlineFn`.
@khauthanhhieu
Copy link

please merge this, just one line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet