Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build-demo command not working #35

Closed
joepio opened this issue Apr 13, 2016 · 4 comments
Closed

npm run build-demo command not working #35

joepio opened this issue Apr 13, 2016 · 4 comments

Comments

@joepio
Copy link

joepio commented Apr 13, 2016

In this commit, the build-demo script was removed from the package.json file.

Adding the line "build-demo": "webpack", to the package.json file solved the issue for me. Perhaps the readme should be updated or the script should be added back.

@sstur
Copy link
Owner

sstur commented Apr 14, 2016

build-demo was replaced with build-dist which should create both dist/demo.js and dist/react-rte.js. In fact, npm build will both generate some lib/ files and also run build-dist.

Does this help?

@sstur sstur closed this as completed Apr 14, 2016
@joepio
Copy link
Author

joepio commented Apr 14, 2016

I assume it does, but the readme still says:
Clone this project. Run npm install. Run npm run build-demo then point the server of your choice (like serv) to /demo.html.

@sstur
Copy link
Owner

sstur commented Apr 14, 2016

Oh, good catch! I'll update now.

@sstur
Copy link
Owner

sstur commented Apr 14, 2016

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants