Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeName of undefined in IE 11? #56

Closed
zackify opened this issue May 31, 2016 · 7 comments
Closed

nodeName of undefined in IE 11? #56

zackify opened this issue May 31, 2016 · 7 comments

Comments

@zackify
Copy link
Contributor

zackify commented May 31, 2016

screen shot 2016-05-31 at 4 18 53 pm

This happens when loading in the editor. It doesn't show up. Not sure if this is a problem due to draftjs itself or due to react-rte. Only happens on IE 11 like I said. Can't stand IE....

@zackify
Copy link
Contributor Author

zackify commented Jun 22, 2016

Using this on constructionjobs.com and would really love it if I could get some help with making this work in IE 11, if you point me in the right direction I could fix it.

@sstur
Copy link
Owner

sstur commented Jun 23, 2016

Hi @zackify. Sorry for the delay. I think this error is in draft-js-import-element which react-rte depends on. I'll see if I can figure out why IE11 is braking there..

@zackify
Copy link
Contributor Author

zackify commented Jun 23, 2016

Awesome I'll check it out too.
On Wed, Jun 22, 2016 at 20:00 Simon Sturmer notifications@github.com
wrote:

Hi @zackify https://github.com/zackify. Sorry for the delay. I think
this error is in draft-js-import-element which react-rte depends on. I'll
see if I can figure out why IE11 is braking there..


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#56 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAbacJSbYD8B5lUZ5z-DUEU6KIZZ1of3ks5qOcyFgaJpZM4Iq6pY
.

@zackify
Copy link
Contributor Author

zackify commented Jun 30, 2016

So I finally checked this out today. Seems the only problem is an element being passed in as null in IE 11 when there's no value inside of the editor. I made a 1 line pull request that fixes the issue. Hopefully you can merge it and make a new release because I need this fix asap! Thanks for pointing me in the right direction. sstur/draft-js-import-element#14

There may be a more correct way to fix this, but I don't have time to look over the whole import-element script.

@sstur
Copy link
Owner

sstur commented Jul 1, 2016

Hi @zackify. Sorry for the wait on this. And thanks for your pull request. I'll merge it and publish an update asap.

@sstur
Copy link
Owner

sstur commented Jul 1, 2016

Done.

@zackify
Copy link
Contributor Author

zackify commented Jul 1, 2016

Thanks for doing that so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants