Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/style loader #217

Merged
merged 3 commits into from
Jul 18, 2017
Merged

Patch/style loader #217

merged 3 commits into from
Jul 18, 2017

Conversation

jooj123
Copy link
Contributor

@jooj123 jooj123 commented Jul 18, 2017

Update to latest style loader to fix critical SSR issue:
webpack-contrib/style-loader#196

@jooj123
Copy link
Contributor Author

jooj123 commented Jul 18, 2017

Hmm actually this doesnt fix the issue - just causes it to have the same issue where window is not defined and pointing to:

}, isOldIE = memoize(function() {
        // Test for IE <= 9 as proposed by Browserhacks
        // @see http://browserhacks.com/#hack-e71d8692f65334173fee715c222cb805
        // Tests for existence of standard globals is to allow style-loader
        // to operate correctly into non-standard environments
        // @see https://github.com/webpack-contrib/style-loader/issues/177
        return window && document && document.all && !window.atob;
    }), getElement = function(fn) {

Any reason why style-loader stuff is in the transpiled output ?
Any way for SSR to work without webpack ?

@bherila
Copy link
Collaborator

bherila commented Jul 18, 2017

I will merge this because there isn't any breaking change in the style loader version, but if you would like to eliminate the window dependency you will need to use your own webpack config with a style loader of your choice and import 'react-rte/lib/RichTextEditor' as described in 0a15bf3

@bherila bherila merged commit 05bf61f into sstur:master Jul 18, 2017
@jooj123
Copy link
Contributor Author

jooj123 commented Jul 26, 2017

thanks @bherila !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants