Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: various attempts at nyc config #236

Closed
wants to merge 1 commit into from
Closed

WIP: various attempts at nyc config #236

wants to merge 1 commit into from

Conversation

JaKXz
Copy link

@JaKXz JaKXz commented Feb 23, 2019

Issue

List the issue(s) resolved or addressed by this change.

Changes MUST be related to an issue. If one does not exist, please create one with
the appropriate issue type.

Check

Before creating a PR, please ensure
all merge requirements are met:

  • Gitlab pipeline has passed
  • lint warnings have not increased
  • documentation has been updated
  • tests have been added and consistently pass

Todo

If this PR is still a work in progress, please prefix the title with WIP: and include the remaining tasks:

  • next thing
  • last thing

@ssube
Copy link
Owner

ssube commented Feb 23, 2019

This pull request introduces 1 alert when merging 199288f into 002034c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@JaKXz
Copy link
Author

JaKXz commented Feb 24, 2019

closing, see ssube/noicejs#32

@JaKXz JaKXz closed this Feb 24, 2019
@ssube ssube mentioned this pull request Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants