Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX acceleration for Real ESRGAN v3 #113

Closed
ssube opened this issue Feb 7, 2023 · 1 comment · Fixed by #175
Closed

ONNX acceleration for Real ESRGAN v3 #113

ssube opened this issue Feb 7, 2023 · 1 comment · Fixed by #175
Assignees
Labels
model/upscaling status/fixed issues that have been fixed and released type/feature new features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 7, 2023

Because v3 is using SRVGGNetCompact instead of RRDBNet, it's not using the ONNX shim and is always running on CPU. Fix that.

https://github.com/ssube/onnx-web/blob/main/api/onnx_web/chain/upscale_resrgan.py#L40

@ssube ssube added status/new issues that have not been confirmed yet type/feature new features labels Feb 7, 2023
@ssube ssube added this to the v0.8 milestone Feb 12, 2023
@ssube
Copy link
Owner Author

ssube commented Feb 18, 2023

Using the current OnnxNet runs, but not well:

image

@ssube ssube added status/progress issues that are in progress and have a branch and removed status/new issues that have not been confirmed yet labels Feb 18, 2023
@ssube ssube self-assigned this Feb 18, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Feb 18, 2023
@ssube ssube closed this as completed Feb 18, 2023
@ssube ssube mentioned this issue Mar 5, 2023
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model/upscaling status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant