Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.0 release checklist #217

Closed
97 of 99 tasks
ssube opened this issue Mar 5, 2023 · 3 comments
Closed
97 of 99 tasks

v0.8.0 release checklist #217

ssube opened this issue Mar 5, 2023 · 3 comments
Assignees
Labels
status/fixed issues that have been fixed and released type/release
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Mar 5, 2023

Issues:

Merges:

Testing:

  • txt2img
    • 256x256 with SD v1.5
      • should fail: neon blobs worked, but that's ok
      • has automation
    • 512x512 with SD v1.5
      • DEIS Multi
        • should work
      • DPM Multi
        • should work
        • has automation
      • Euler A
        • should work
      • Heun
        • should work
        • has automation
    • 512x512 with SD v2.1
      • should work
      • has automation
    • 768x768 with SD v2.1
      • should work, given sufficient memory
      • has automation
    • extra models
      • 512x512 with Knollingcase
        • should work
        • has automation
      • 512x512 with OpenJourney
        • should work
        • has automation
      • 256x256 with OpenJourney
        • should work
    • textual inversion
      • 512x512 with SD v1.5 + Autumn (embeddings)
        • should work
      • 512x512 with SD v1.5 + Minecraft (concept)
        • should work
  • img2img
    • 256x256 input
      • should work: expanded into valid image
      • has automation
    • 512x512 input
      • should work
      • has automation
    • 1024x768 input
      • should work
  • inpaint
    • regular inpaint
      • black mask
        • should keep all pixels, same image
        • has automation
      • white mask
        • should replace all pixels, different image
        • has automation
    • outpaint
      • 0 all sides
        • should work, run 1 tile
        • primarily a client-side test
      • 256 all sides
        • should work, run 8 tiles
        • has automation
      • 512 top and bottom, 0 left and right
        • should work, run 3 tiles
        • has automation
      • 512 left and right, 0 top and bottom
        • should work, run 3 tiles
        • has automation
  • upscale
    • Real ESRGAN
      • x4 with CodeFormer
        • should work
      • x4 with GFPGAN
        • should work
      • x4 without face correction
        • should work
        • has automation
      • x2 without face correction
        • should work
        • has automation
      • x2 model and x4 scale
        • should sort of work: ignores scale and uses x2
      • x4 model and x2 scale
        • should fail: tiles
      • v3 model and x4 scale
        • should work
    • Stable Diffusion
      • using x2 scale
        • should fail: tiles
      • using x4 scale
        • should work
      • with CodeFormer
        • should work
      • with GFPGAN
        • should work
      • without face correction
        • should work
  • blend
    • two 512x512 inputs
      • should work
    • two 1024x1024 inputs
      • should work
    • two different size inputs
      • 256x256 and 512x512
        • should work
      • 512x512 and 1024x1024
        • should work
  • interactions
    • generate a new image
      • should request and then load an image from the server
    • delete a pending image
      • should remove a single image and leave the rest
    • delete a finished image
      • should remove a single image and leave the rest
    • copy an image to img2img
      • should switch to the img2img tab
      • should populate the image source
      • the generate button should be enabled
    • copy an image to inpaint
      • should switch to the inpaint tab
      • should populate the image source
      • the generate button should be enabled
    • copy an image to upscale
      • should switch to the upscale tab
      • should populate the image source
      • the generate button should be enabled
    • copy two images to blend
      • should switch to the blend tab
      • should populate the image sources
      • the generate button should be enabled once both sources have been populated
    • state should persist on refresh
      • loading images
      • switching tabs
      • images sources do not
  • schedulers
    • DDIM
    • DDPM
    • DEIS Multi
    • DPM Multi
    • DPM Single
    • Euler A
    • Euler
    • Heun
    • iPNDM
    • KDPM2 A
    • KDPM2
    • Karras Ve
    • LMS
    • PNDM
    • UniPC Multi

Release:

  • fix any late arrival bugs
  • check on/add UniPCMultistepScheduler
  • document ONNX_WEB_EXTRA_ARGS
  • more bugs
  • update release tests to include Textual Inversions
  • check and fix lint
  • update package versions and stage files
  • run commit-and-tag-version --sign --git-tag-fallback --commit-all --release-as=minor to make VERSION
  • make sure packages and images have been built
  • update GH pages bundle and default version
  • post release on GH
  • make follow up tickets
  • close milestone and checklist
@ssube ssube added status/progress issues that are in progress and have a branch type/release labels Mar 5, 2023
@ssube ssube added this to the v0.8 milestone Mar 5, 2023
@ssube ssube self-assigned this Mar 5, 2023
@ssube
Copy link
Owner Author

ssube commented Mar 7, 2023

There are a few bugs around model conversion that still need to be fixed, as well as LoRA token expansion.

@ssube
Copy link
Owner Author

ssube commented Mar 9, 2023

All of the bugs that have been reported so far have been fixed, and the release test script passed on my Win10 + AMD + DirectML and Ubuntu + Nvidia + CUDA systems. Unfortunately, my Ubuntu + AMD + ROCm test machine is not cooperating, so I need to fix that or will have to release without specifically testing ROCm, which I don't like very much.

The new ONNX_WEB_EXTRA_ARGS variable still needs to be documented and I need to check if the UniPCMultistepScheduler can be added yet.

@ssube
Copy link
Owner Author

ssube commented Mar 11, 2023

  • the Karras Ve scheduler is still broken (TypeError: KarrasVeScheduler.step() missing 1 required positional argument: 'sample_hat')
  • iPNDM is still producing chips (LMS and PNDM may as well without enough steps)
  • the Generate button on the Blend tab is enabled even without the second source

@ssube ssube closed this as completed Mar 11, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/release
Projects
None yet
Development

No branches or pull requests

1 participant