Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for LoRA weights #157

Closed
ssube opened this issue Feb 16, 2023 · 3 comments
Closed

add support for LoRA weights #157

ssube opened this issue Feb 16, 2023 · 3 comments
Assignees
Labels
status/fixed issues that have been fixed and released type/feature new features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 16, 2023

https://huggingface.co/docs/diffusers/training/lora#inference

@ssube ssube added status/new issues that have not been confirmed yet type/feature new features labels Feb 16, 2023
@ssube ssube added this to the v0.8 milestone Feb 16, 2023
@ssube ssube added status/blocked in-progress issues that are blocked by a dependency and removed status/new issues that have not been confirmed yet labels Feb 16, 2023
@ssube ssube self-assigned this Feb 16, 2023
@ssube
Copy link
Owner Author

ssube commented Feb 16, 2023

This is working for some weights, like the reference at https://huggingface.co/sayakpaul/sd-model-finetuned-lora-t4, but failing for many of the files tagged as LoRA on Civitai with an error about missing metadata: cloneofsimo/lora#191

@ssube
Copy link
Owner Author

ssube commented Feb 18, 2023

I have this working for both weights produced by https://github.com/cloneofsimo/lora and https://github.com/kohya-ss/sd-scripts, like https://civitai.com/models/8039/jackscape-samurai-jack-background-style-lora:

image

This is not a one-step process yet and relies on both of those repositories, so there's quite a bit of work to still be done, but it is possible.

@ssube ssube added status/progress issues that are in progress and have a branch and removed status/blocked in-progress issues that are blocked by a dependency labels Feb 18, 2023
@ssube
Copy link
Owner Author

ssube commented Feb 19, 2023

This is now documented: https://github.com/ssube/onnx-web/blob/main/docs/converting-models.md

I'm not sure if the one-step conversion will make v0.8 or come later, but it can be done manually and the resulting ONNX models can be shared.

@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Feb 19, 2023
@ssube ssube closed this as completed Feb 20, 2023
@ssube ssube mentioned this issue Mar 5, 2023
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Development

No branches or pull requests

1 participant