Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix any remaining memory leaks #162

Closed
ssube opened this issue Feb 16, 2023 · 2 comments
Closed

fix any remaining memory leaks #162

ssube opened this issue Feb 16, 2023 · 2 comments
Labels
scope/api status/fixed issues that have been fixed and released type/bug broken features

Comments

@ssube
Copy link
Owner

ssube commented Feb 16, 2023

#136 should help reduce memory usage and allows turning off the cache entirely with ONNX_WEB_CACHE_MODELS=0. With that, memory usage appears to drop back to baseline between runs on Ubuntu 22, but I need to test it on Windows as well.

There are some remaining issues or limitations with the current cache:

  • if the cache limit is > 0, you can still exhaust memory by loading very large models
    • the default limit of 3 and SD v2.1 models in fp32 will easily max out a 24GB card
@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 16, 2023
@ssube
Copy link
Owner Author

ssube commented Mar 17, 2023

@ssube ssube added status/progress issues that are in progress and have a branch and removed status/new issues that have not been confirmed yet labels Mar 17, 2023
@ssube ssube modified the milestone: v0.9 Mar 18, 2023
@ssube
Copy link
Owner Author

ssube commented Dec 3, 2023

#242 remains an issue on Windows, but is related to the DirectML runtime/drivers, and not something I can currently fix. Restarting the workers still works there.

@ssube ssube closed this as completed Dec 3, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/api status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant