Fix CPU memory leak due to external weights not getting memory unmapped when using non-CPU EP. #15040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using non-CPU EP.
skottmckay
reviewed
Mar 15, 2023
| @@ -161,9 +161,11 @@ static common::Status DeserializeTensorProto(const Env& env, const std::basic_st | |||
| } | |||
|
|
|||
| OrtCallback ext_data_deleter; | |||
| ScopedOrtCallbackInvoker scoped_ort_callback_invoker; | |||
| if (utils::HasExternalData(tensor_proto)) { | |||
There was a problem hiding this comment.
Could you use std::optional to avoid the changes to callback.h?
There was a problem hiding this comment.
I can, but in general RAII classes should also have a default constructor (like unique_ptr, shared_ptr, scoped_ptr) and a way to either reset its contents or copy/move them. Hence the change to callback.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CPU memory leak due to external weights not getting memory unmapped when using non-CPU EP.
Sample program that creates a session in a loop of 5
Before (1.14.1 release)
After
Motivation and Context
Fixes #14466 and a bunch of others