Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.8 to CI or drop support for it #354

Closed
ssube opened this issue Apr 25, 2023 · 0 comments
Closed

add python 3.8 to CI or drop support for it #354

ssube opened this issue Apr 25, 2023 · 0 comments
Labels
provider/cuda scope/build status/fixed issues that have been fixed and released type/bug broken features
Milestone
v0.10

Comments

@ssube
Copy link
Owner

ssube commented Apr 25, 2023

The CUDA image is based on Python 3.8, which uses type hints differently from 3.9 and better. I keep using the 3.9+ types by accident and CI is not catching it.

Either set up a CI job to run the unit tests using 3.8, or install 3.9/3.10 in the CUDA image and drop support for 3.8.
@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features scope/build provider/cuda labels Apr 25, 2023
@ssube ssube added this to the v0.10 milestone Apr 25, 2023
@ssube ssube added status/progress issues that are in progress and have a branch and removed status/new issues that have not been confirmed yet labels Apr 28, 2023
@ssube ssube mentioned this issue May 1, 2023
Closed
ssube added a commit that referenced this issue May 5, 2023
@ssube
fix(build): run tests on python 3.8 and 3.9 (#354)
08a23ed
@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels May 5, 2023
@ssube ssube closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
provider/cuda scope/build status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Milestone
v0.10
Development

No branches or pull requests
1 participant
@ssube