Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load config from a URL relative to the index page #43

Closed
ssube opened this issue Jan 14, 2023 · 0 comments · Fixed by #44
Closed

load config from a URL relative to the index page #43

ssube opened this issue Jan 14, 2023 · 0 comments · Fixed by #44
Labels
status/fixed issues that have been fixed and released type/feature new features
Milestone
v0.4

Comments

@ssube
Copy link
Owner

ssube commented Jan 14, 2023

The config.json file is being loaded from ./config.json on the page origin, not the page path, which is breaking Github pages. Load the config from a path relative to the page's path, which will not change the behavior when the index is not under a subdirectory.
ssube added a commit that referenced this issue Jan 14, 2023
@ssube
fix(gui): load config relative to current page (fixes #43)
d114ab2
ssube added a commit that referenced this issue Jan 14, 2023
@ssube
update bundle with fix for #43
feb415c
@ssube ssube added this to the v0.4 milestone Jan 14, 2023
@ssube ssube added status/fixed issues that have been fixed and released type/feature new features labels Jan 14, 2023
@ssube ssube mentioned this issue Jan 14, 2023
Merged
@ssube ssube closed this as completed in #44 Jan 14, 2023
@ssube ssube closed this as completed in 2e5c786 Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

persist source and mask ssube/onnx-web
1 participant
@ssube