fix(server): ensure complete http header is present

prometheus_express/server.py

@@ -77,6 +77,9 @@ def parse_headers(self, req):
         lines = req.split(http_break)
         start = lines[0].split(' ')
 
+        if len(start) < 3:
+            raise ValueError('request does not have all HTTP components')
+
         return ({
             'method': start[0],
             'path': start[1],

tests/test_server.py

@@ -0,0 +1,67 @@
+import unittest
+import prometheus_express.router as pr
+import prometheus_express.server as ps
+
+class MockConnection(object):
+  def __init__(self, body):
+    self.accum = []
+    self.body = body
+    self.buffer = []
+    self.index = 0
+    self.open = True
+
+  def recv(self, n):
+    print('recv', n)
+    self.buffer = self.body[self.index : self.index + n]
+    self.index += n
+    return self.buffer
+
+  def send(self, chunk):
+    self.accum.append(chunk)
+
+  def close(self):
+    self.open = False
+
+  def response(self):
+    return ''.join(self.accum)
+
+class MockSocket(object):
+  def __init__(self, addr, body):
+    self.addr = addr
+    self.body = body
+    self.conn = MockConnection(self.body)
+
+  def accept(self):
+    return (self.conn, self.addr)
+
+class ServerAcceptTest(unittest.TestCase):
+  def test_valid(self):
+    body = 'test body'
+    mock = MockSocket('0.0.0.1', 'GET / HTTP/1.1\r\n{}'.format(body))
+
+    s = ps.Server(mock)
+    r = pr.Router([
+      ('GET', '/', lambda headers, requestBody: {
+        'content': body,
+        'status': 200,
+      }),
+    ])
+    s.accept(r)
+
+    result = mock.conn.response()
+    self.assertEqual(
+      result.split('\r\n')[-1],
+      body
+    )
+
+  def test_missing_verb(self):
+    body = 'test body'
+    mock = MockSocket('0.0.0.1', 'HTTP/1.1\r\n{}'.format(body))
+
+    s = ps.Server(mock)
+    r = pr.Router([
+      ('GET', '/', lambda: body),
+    ])
+
+    with self.assertRaises(ValueError):
+      s.accept(r)