Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple state step loop from render service #63

Closed
ssube opened this issue May 21, 2021 · 0 comments
Closed

decouple state step loop from render service #63

ssube opened this issue May 21, 2021 · 0 comments
Assignees
@ssube
Labels
scope/render user IO abstraction status/fixed issues that have been fixed and confirmed type/feature
Milestone
v1.3

Comments

@ssube
Copy link
Owner

ssube commented May 21, 2021

The bulk of the current BaseRender.loop method should live in the StateService, consuming line events from the render service/system/React tree, and emitting step events which will update the render output.
@ssube ssube added status/new issues that have not been addressed yet type/feature scope/render user IO abstraction labels May 21, 2021
@ssube ssube added this to the v1.3 milestone May 21, 2021
@ssube ssube self-assigned this May 21, 2021
@ssube ssube added status/progress issues that are in progress and removed status/new issues that have not been addressed yet labels May 22, 2021
ssube added a commit that referenced this issue May 22, 2021
@ssube
feat: make state event emitter, consume events from render (#63)
3722671
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/progress issues that are in progress labels May 22, 2021
@ssube ssube closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/render user IO abstraction status/fixed issues that have been fixed and confirmed type/feature
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
1 participant
@ssube