Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Thread::user_single_step()' can disable interrupts #2

Closed
cproc opened this issue Mar 11, 2013 · 1 comment
Closed

'Thread::user_single_step()' can disable interrupts #2

cproc opened this issue Mar 11, 2013 · 1 comment

Comments

@cproc
Copy link

cproc commented Mar 11, 2013

In the Thread::user_single_step() function, the statement

regs()->flags(enable ? user_flags() | EFLAGS_TF : user_flags() & ~EFLAGS_TF);

can clear the interrupt flag, because with the Ex_regs: Change 'user_flags' patch applied, the user_flags() function does not return the previous CPU flags anymore, but the thread state.
cproc added a commit to cproc/foc that referenced this issue Mar 11, 2013
@cproc
Fix 'Thread::user_single_step()'
d02d8c6 
Fixes ssumpf#2.
@cproc
Copy link
Author

cproc commented Mar 11, 2013

Fixed in cproc@d02d8c6

ssumpf added a commit that referenced this issue Mar 14, 2013
@ssumpf
FOC: Fix 'user_flags' on x86
658efae 
Use carry bit in EFLAGS to pass thread state to ex_reg caller. Do not touch
other bits, which might disable interrupts on kernel exit.

Fixes #2.
@ssumpf ssumpf closed this as completed Mar 14, 2013
BugUser0815 added a commit to BugUser0815/foc that referenced this issue Aug 26, 2019
@BugUser0815
Merge pull request ssumpf#2 from BugUser0815/r78
1b2047d 
R78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cproc @ssumpf