test(utils): cover more scopes

TODO: mock legacy TKK code
ssut · Jun 10, 2020 · 44957eb · 44957eb
1 parent 5460f43
commit 44957eb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/googletrans/client.py b/googletrans/client.py
@@ -45,7 +45,7 @@ def __init__(self, service_urls=None, user_agent=DEFAULT_USER_AGENT,
                  proxies: typing.Dict[str, httpcore.SyncHTTPTransport] = None, timeout: Timeout = None):
 
         self.client = httpx.Client()
-        if proxies is not None:
+        if proxies is not None:  # pragma: nocover
             self.client.proxies = proxies
         self.client.headers.update({
             'User-Agent': user_agent,

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -5,20 +5,36 @@
 def test_format_json():
     text = '[,,"en",,,,0.96954316,,[["en"],,[0.96954316]]]'
 
-    result = utils.legacy_format_json(text)
+    result = utils.format_json(text)
 
     assert result == [None, None, 'en', None, None, None, 0.96954316, None,
                       [['en'], None, [0.96954316]]]
 
+
 def test_format_malformed_json():
     text = '[,,"en",,,,0.96954316,,[["en"],,0.96954316]]]'
 
     with raises(ValueError):
-        utils.legacy_format_json(text)
+        utils.format_json(text)
+
 
 def test_rshift():
     value, n = 1000, 3
 
     result = utils.rshift(value, n)
 
     assert result == 125
+
+
+def test_build_params_with_override():
+    params = utils.build_params(
+        query='',
+        src='',
+        dest='',
+        token='',
+        override={
+            'otf': '3',
+        },
+    )
+
+    assert params['otf'] == '3'