Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ change TestingSyncCommitteeBlockRoot to non zero #176

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

alonmuroch
Copy link
Contributor

@alonmuroch alonmuroch commented Mar 21, 2023

issue found with SSZ32Bytes unmarshaling not having a pointer and thus never un-marshaling data.
Tests passed as TestingSyncCommitteeBlockRoot was 32 byte of zeros

  • Change TestingSyncCommitteeBlockRoot to non zero values
  • fix SSZ32Bytes unmarshal to pointer to take effect

@alonmuroch alonmuroch closed this Mar 21, 2023
@alonmuroch alonmuroch merged commit 66c1585 into ssvlabs:main Mar 21, 2023
@alonmuroch alonmuroch deleted the fix-block-root-test-zeros branch March 21, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant