Type test: share #337
Merged
Type test: share #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
10
to
23
| func NoQuorum() *ShareTest { | ||
| ks := testingutils.Testing4SharesSet() | ||
| share := testingutils.TestingShare(ks) | ||
|
|
||
| msg := testingutils.TestingCommitMultiSignerMessage([]*bls.SecretKey{ks.Shares[1], ks.Shares[2]}, []types.OperatorID{1, 2}) | ||
|
|
||
| return &ShareTest{ | ||
| Name: "no quorum", | ||
| Share: *share, | ||
| Message: *msg, | ||
| ExpectedHasPartialQuorum: true, | ||
| ExpectedHasQuorum: false, | ||
| ExpectedFullCommittee: false, | ||
| } |
There was a problem hiding this comment.
The logic is pretty much the same as has_partial_quroum?
If so maybe we might as well delete this test and change the name of has_partial_quorum to account for 2 scenarios?
Having the same test for 2 different scenarios might also be an ok approach, but I think we have enough clutter in our tests anyhow
GalRogozinski
approved these changes
Jan 10, 2024
MatusKysel
reviewed
Jan 15, 2024
Comment on lines
+27
to
+35
| func (test *ShareTest) GetUniqueMessageSignersCount() int { | ||
| uniqueSigners := make(map[uint64]bool) | ||
|
|
||
| for _, element := range test.Message.Signers { | ||
| uniqueSigners[element] = true | ||
| } | ||
|
|
||
| return len(uniqueSigners) | ||
| } |
There was a problem hiding this comment.
Suggested change
| func (test *ShareTest) GetUniqueMessageSignersCount() int { | |
| uniqueSigners := make(map[uint64]bool) | |
| for _, element := range test.Message.Signers { | |
| uniqueSigners[element] = true | |
| } | |
| return len(uniqueSigners) | |
| } | |
| func (test *ShareTest) GetUniqueMessageSignersCount() int { | |
| uniqueSigners := make(map[uint64]struct{}) | |
| for _, signer := range test.Message.Signers { | |
| uniqueSigners[signer] = struct{}{} | |
| } | |
| return len(uniqueSigners) | |
| } |
not anything crucial, but this is more memory-efficient since it doesn't actually store any data
MatusKysel
reviewed
Jan 15, 2024
| @@ -96,6 +96,12 @@ func TestJson(t *testing.T) { | |||
| typedTest := &beacon.DepositDataSpecTest{} | |||
| require.NoError(t, json.Unmarshal(byts, &typedTest)) | |||
| typedTest.Run(t) | |||
| case reflect.TypeOf(&share.ShareTest{}).String(): | |||
| byts, err := json.Marshal(test) | |||
MatusKysel
approved these changes
Jan 15, 2024
y0sher
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec Test
New test type to verify share's functionality of checking quorums.
Tests:
Solving one element of issue 25.